MAINT: pyproject, pysat style updates#137
Merged
Merged
Conversation
jklenzing
commented
Dec 20, 2023
jklenzing
commented
Dec 20, 2023
10 tasks
25 tasks
aburrell
reviewed
Dec 21, 2023
| if(pack_version.Version(pysat.__version__) | ||
| > pack_version.Version('3.0.1')): | ||
| load_kwargs['use_header'] = True | ||
| load_kwargs['use_header'] = True |
Member
There was a problem hiding this comment.
Recommend keeping the version test, but add a max version for this as well.
if all([Version(pysat.__version__) > Version('3.0.1'),
Version(pysat.__version__) < Version('3.2.0')]):
inst_kwargs['use_header'] = True
Member
Author
There was a problem hiding this comment.
Since the requirements files specifies a minimum of pysat 3.0.4, should we just proceed with the maximum cap?
aburrell
approved these changes
Dec 21, 2023
Member
Author
|
LOL, just remembered why I didn't merge this one last month. The new tests flag wasn't finalized. Incoming PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #134, #131
NOTE: added backwards compat for pre-1.4 pandas for the operational server. pandas 1.1.5 is the maximum version supported there.
DOUBLE NOTE: The ICON TIEGCM feature is currently broken until pysatNASA 0.0.6 is released. Future fix in place with #132. This branch turns off testing temporarily until the next releases of pysat and pysatNASA are complete. TODO statements flag what needs to be updated. The pysatNASA cap of 0.0.4 is still required to trick the operational environment into behaving.
Uses the
_test_new_testsinstrument attribute to skip the multi-day tests for broken instruments, documented in #136. Implementation in pysat is in pysat/pysat#1166Type of change
How Has This Been Tested?
Tested against pysat 3.2.0 RC1 and pysat/pysat#1166
Test Configuration:
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release